commit 94dd98df0ce2eb127cbd06d0496cf31e582bba69
parent 35a95f054c7849fae3a602407a2d33583a48624f
Author: francoispqt <francois@parquet.ninja>
Date: Thu, 20 Dec 2018 16:38:23 +0800
change pool error tests in encoder to not call release to avoid race errors
Diffstat:
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/encode_bool_test.go b/encode_bool_test.go
@@ -43,7 +43,7 @@ func TestEncoderBoolErrors(t *testing.T) {
t.Run("pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := BorrowEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err shouldnt be nil")
diff --git a/encode_embedded_json_test.go b/encode_embedded_json_test.go
@@ -124,7 +124,7 @@ func TestEncodingEmbeddedJSON(t *testing.T) {
t.Run("pool-error", func(t *testing.T) {
v := EmbeddedJSON([]byte(`"test"`))
enc := BorrowEncoder(nil)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err shouldnt be nil")
diff --git a/encode_interface_test.go b/encode_interface_test.go
@@ -153,7 +153,7 @@ func TestEncoderInterfaceEncodeAPI(t *testing.T) {
v := ""
w := TestWriterError("")
enc := BorrowEncoder(w)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
diff --git a/encode_number_test.go b/encode_number_test.go
@@ -73,7 +73,7 @@ func TestEncoderNumberEncodeAPIErrors(t *testing.T) {
t.Run("encode-int-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
@@ -92,7 +92,7 @@ func TestEncoderNumberEncodeAPIErrors(t *testing.T) {
t.Run("encode-int64-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
@@ -112,7 +112,7 @@ func TestEncoderNumberEncodeAPIErrors(t *testing.T) {
t.Run("encode-uint64-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
@@ -132,7 +132,7 @@ func TestEncoderNumberEncodeAPIErrors(t *testing.T) {
t.Run("encode-float64-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
@@ -151,7 +151,7 @@ func TestEncoderNumberEncodeAPIErrors(t *testing.T) {
t.Run("encode-float32-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")
diff --git a/encode_object_test.go b/encode_object_test.go
@@ -417,7 +417,7 @@ func TestEncoderObjectEncodeAPIError(t *testing.T) {
t.Run("pool-error", func(t *testing.T) {
v := &TestEncoding{}
enc := BorrowEncoder(nil)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err shouldnt be nil")
@@ -608,7 +608,7 @@ func TestEncodeObjectWithKeys(t *testing.T) {
t.Run("pool-error", func(t *testing.T) {
v := &TestEncoding{}
enc := BorrowEncoder(nil)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err shouldnt be nil")
diff --git a/encode_string_test.go b/encode_string_test.go
@@ -122,7 +122,7 @@ func TestEncoderStringEncodeAPIErrors(t *testing.T) {
t.Run("pool-error", func(t *testing.T) {
v := ""
enc := BorrowEncoder(nil)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err shouldnt be nil")
diff --git a/encode_time_test.go b/encode_time_test.go
@@ -41,7 +41,7 @@ func TestEncodeTime(t *testing.T) {
t.Run("encode-time-pool-error", func(t *testing.T) {
builder := &strings.Builder{}
enc := NewEncoder(builder)
- enc.Release()
+ enc.isPooled = 1
defer func() {
err := recover()
assert.NotNil(t, err, "err should not be nil")